-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#107: Swift Package Manager support #109
base: master
Are you sure you want to change the base?
Conversation
* add Package.swift * Update Package.swift * scheme build * add Rx support * rename from "+" * set empty dependencies for main target * update readme
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
==========================================
- Coverage 97.80% 95.97% -1.84%
==========================================
Files 8 8
Lines 273 273
==========================================
- Hits 267 262 -5
- Misses 6 11 +5
Continue to review full report at Codecov.
|
@fjcaetano you have any idea why codecov showing this? there was no change in this file that could impact coverage in this configuration |
@JakubMazur I apologize for the delay. I tried taking a quick look at this a few days back, but I was having issues when I tried refactoring the Examples project to leverage SPM instead of Cocoapods. I wasn't able to install the package locally, like Cocoapods does with I'll try to get back to this soon when I'm a bit more free. In the mean time, don't worry about Codecov. It's complaining because this PR reduces code coverage, but that's expected since you're adding config files that aren't testable. |
If you want to switch example project to use SPM instead of Cocoapods I can have a look and submit code changes to this PR |
* process recaptcha.html * use module
@fjcaetano You can drag the folder containing Package.swift directly into the Xcode Project to locally reference the package. |
what's the latest state regarding SPM support? Is there a way/branch/... to use ReCaptcha with SPM? |
@haemi you can use my fork: but unsure if this will work with Cocoapods as in discussion above. Although it is working with SPM |
@fjcaetano Anything we can do to help push this through? One of the last packages not moved over to SwiftPM yet for us. |
any updates on this? @fjcaetano |
Any updates on the SPM implementation? |
@fjcaetano Anything we can do to help push this through? |
Swift Package Manager Support #107
Swift Package Manager added to both
Rx
and main target.pod spec lint
carhage build --archive
swift build
for iOS targetKnown issues:
AppSwizzle
that frameworks is using as test target does not support SPM yet. I open PR with support to SPM there, but project looks abandoned. SPM test target has then dependency to my fork of this project with SPM SupportRx
version will see resolved package in Xcode that will not be linked to a binary later or usable in a project. Here is my StackOverflow question on this topic that leads me to open ticket SR-8658. AFAIK there is no walkaround for it.TODO:
#108: after merge and tag a new version update a package to Swift Package Index